Re: [PATCH v2 09/11] platform/x86:intel/pmc: Add Lunar Lake SSRAM devid

[Ilpo Järvinen]

On Wed, 28 Aug 2024, Xi Pardee wrote:

> Enable SSRAM device Lunar Lake support by adding Lunar Lake SSRAM
> devid to Intel SSRAM Telemetry driver.
> 
> Signed-off-by: Xi Pardee <xi.pardee@xxxxxxxxxxxxxxx>
> ---
>  drivers/platform/x86/intel/pmc/core.h            | 3 +++
>  drivers/platform/x86/intel/pmc/ssram_telemetry.c | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/pmc/core.h b/drivers/platform/x86/intel/pmc/core.h
> index 2d62a71ec100..25974f9d329e 100644
> --- a/drivers/platform/x86/intel/pmc/core.h
> +++ b/drivers/platform/x86/intel/pmc/core.h
> @@ -300,6 +300,9 @@ enum ppfear_regs {
>  #define PMC_DEVID_MTL_IOEP	0x7ecf
>  #define PMC_DEVID_MTL_IOEM	0x7ebf
>  
> +/* LNL */
> +#define PMC_DEVID_LNL_SOCM	0xa87f
> +
>  extern const char *pmc_lpm_modes[];
>  
>  struct pmc_bit_map {
> diff --git a/drivers/platform/x86/intel/pmc/ssram_telemetry.c b/drivers/platform/x86/intel/pmc/ssram_telemetry.c
> index 1c6cc95bfefa..025013b051c7 100644
> --- a/drivers/platform/x86/intel/pmc/ssram_telemetry.c
> +++ b/drivers/platform/x86/intel/pmc/ssram_telemetry.c
> @@ -165,6 +165,7 @@ static int intel_pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct
>  static const struct pci_device_id intel_pmc_ssram_telemetry_pci_ids[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_MTL_SOCM) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCS) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_LNL_SOCM) },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(pci, intel_pmc_ssram_telemetry_pci_ids);
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

-- 
 i.