Re: [PATCH net-next v1] brcmfmac: Convert to use ERR_CAST()

From: Kalle Valo
Date: Thu Aug 29 2024 - 08:23:36 EST


Yuesong Li <liyuesong@xxxxxxxx> writes:

> Use ERR_CAST() as it is designed for casting an error pointer to
> another type.
>
> This macro utilizes the __force and __must_check modifiers, which instruct
> the compiler to verify for errors at the locations where it is employed.
>
> Signed-off-by: Yuesong Li <liyuesong@xxxxxxxx>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)

Several problems:

* wireless patches go to wireless-next, not net-next

* "wifi:" missing from title

* you forgot to cc linux-wireless

Please fix these and submit v2. And please read the wiki link below.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches