Re: [PATCH v4 7/7] iio: pressure: bmp280: Move bmp085 interrupt to new configuration

From: Andy Shevchenko
Date: Thu Aug 29 2024 - 08:49:14 EST


On Wed, Aug 28, 2024 at 10:51:27PM +0200, Vasileios Amoiridis wrote:
> This commit intends to add the old BMP085 sensor to the new IRQ interface
> of the driver for consistence. No functional changes intended.
>
> The BMP085 sensor is equivalent with the BMP180 with the only difference of
> BMP085 having an extra interrupt pin to inform about an End of Conversion.

...

> +static int bmp085_trigger_probe(struct iio_dev *indio_dev)
> {
> + struct bmp280_data *data = iio_priv(indio_dev);
> + struct device *dev = data->dev;
> unsigned long irq_trig;
> - int ret;
> + int ret, irq;
> +
> + irq = fwnode_irq_get(dev_fwnode(data->dev), 0);

You have dev, use it!

> + if (irq < 0)
> + return dev_err_probe(data->dev, irq, "No interrupt found.\n");

Ditto!

--
With Best Regards,
Andy Shevchenko