Re: [PATCH RFC/RFT net-next] net: stmmac: drop the ethtool begin() callback

[Andrew Halaney]

On Wed, Aug 28, 2024 at 05:35:41PM GMT, Dmitry Dolenko wrote:
> Are there any updates on this topic?
> 
> We are faced with the fact that we can not read or change settings of
> interface while it is down, and came up with the same solution for this
> problem.
> 
> I do not know if Reviewed-by and Tested-by are suitable for patch marked as
> RFC but I will post mine in case it is acceptable here.
> 
> Reviewed-by: Dmitry Dolenko <d.dolenko@xxxxxxxxxxx>
> Tested-by: Dmitry Dolenko <d.dolenko@xxxxxxxxxxx>
> 

In my opinion the tags are welcomed.

I had sort of forgotten about this until your reply, the use case I
had was only to try and force out another bug, so it slipped my mind.

Since both of us were bitten by this, and nobody has indicated it's a bad
idea otherwise, I'll rebase and send v2 with your tags to try and get
this merged.

Thanks,
Andrew