Re: [PATCH v1] cxl/port: Convert to use ERR_CAST()

[Jonathan Cameron]

On Thu, 29 Aug 2024 20:52:35 +0800
Yuesong Li <liyuesong@xxxxxxxx> wrote:

> Use ERR_CAST() as it is designed for casting an error pointer to
> another type.
> 
> This macro utilizes the __force and __must_check modifiers, which instruct
> the compiler to verify for errors at the locations where it is employed.
> 
> Signed-off-by: Yuesong Li <liyuesong@xxxxxxxx>

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

> ---
>  drivers/cxl/core/port.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index 1d5007e3795a..bdd3275ad417 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -941,7 +941,7 @@ struct cxl_root *devm_cxl_add_root(struct device *host,
>  
>  	port = devm_cxl_add_port(host, host, CXL_RESOURCE_NONE, NULL);
>  	if (IS_ERR(port))
> -		return (struct cxl_root *)port;
> +		return ERR_CAST(port);
>  
>  	cxl_root = to_cxl_root(port);
>  	cxl_root->ops = ops;