Re: [PATCH -next v2 00/14] btrfs: Cleaned up folio->page conversion
From: David Sterba
Date: Thu Aug 29 2024 - 11:26:57 EST
On Thu, Aug 29, 2024 at 02:28:54AM +0800, Li Zetao wrote:
> Hi all,
>
> In btrfs, because there are some interfaces that do not use folio,
> there is page-folio-page mutual conversion. This patch set should
> clean up folio-page conversion as much as possible and use folio
> directly to reduce invalid conversions.
>
> This patch set starts with the rectification of function parameters,
> using folio as parameters directly. And some of those functions have
> already been converted to folio internally, so this part has little
> impact.
>
> I have tested with fsstress more than 10 hours, and no problems were
> found. For the convenience of reviewing, I try my best to only modify
> a single interface in each patch.
>
> Josef also worked on converting pages to folios, and this patch set was
> inspired by him[1].
>
> Considering Josef's suggestion[2], this patchset has passed most of the
> xfs/btrfs use cases, include btrfs/060 and btrfs/069.
>
> This patchset is based on commit bcdaf0fe6a52("btrfs: initialize
> last_extent_end to fix -Wmaybe-uninitialized warning in extent_fiemap()")
>
> v1 -> v2:
> * Change clear_page_extent_mapped() to clear_folio_extent_mapped()
> * Fix a bug[3] when folio is valid and it should be unlocked and put
> in copy_inline_to_page().
I've tested the series a few times and so far no problems, the changes
are straightforward. I'll add it to for-next soon. Thanks.