Re: [PATCH v1 05/11] ARM: nvidia: tf701t: add Bluetooth node

From: Thierry Reding
Date: Thu Aug 29 2024 - 11:28:12 EST


On Tue, Aug 06, 2024 at 03:33:58PM GMT, Krzysztof Kozlowski wrote:
> On 06/08/2024 14:39, Svyatoslav Ryhel wrote:
> > Add serial node along with bluetooth node to ASUS TF701T device-tree.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> > ---
> > .../boot/dts/nvidia/tegra114-asus-tf701t.dts | 28 ++++++++++++++++++-
> > 1 file changed, 27 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> > index fe1772250a85..00c3325878b9 100644
> > --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> > +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> > @@ -1111,7 +1111,33 @@ serial@70006040 {
> > };
> >
> > serial@70006200 {
> > - /* Bluetooth */
> > + compatible = "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart";
>
> Why do you override compatible? Boards do not come with different SoCs,
> do they?

Just to clarify this: it's not being overridden because the SoC is
different but because for Bluetooth we need to enable the high-speed
UART mode of these devices, as opposed to the standard UART mode used
for regular serial ports.

Thierry

Attachment: signature.asc
Description: PGP signature