Re: [PATCH] acpi/arm64: Adjust error handling procedure in gtdt_parse_timer_block()

From: Sudeep Holla
Date: Thu Aug 29 2024 - 12:24:56 EST


On Thu, Aug 29, 2024 at 05:17:44PM +0100, Sudeep Holla wrote:
> On Tue, Aug 27, 2024 at 01:12:39PM +0300, Aleksandr Mishin wrote:
> > In case of error in gtdt_parse_timer_block() invalid 'gtdt_frame'
> > will be used in 'do {} while (i-- >= 0 && gtdt_frame--);' statement block
> > because do{} block will be executed even if 'i == 0'.
> >
> > Adjust error handling procedure by replacing 'i-- >= 0' with 'i-- > 0'.
> >
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >
>
> (For some reason I don't see the original email in my inbox, might have
> got blocked 🙁). Anyways LGTM,
>
> Acked-by: Aleksandr Mishin <amishin@xxxxxxxxxx>

Sorry I messed up, I meant

Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx>

--
Regards,
Sudeep