Re: [PATCH] usb: xHCI: add XHCI_RESET_ON_RESUME quirk for Phytium xHCI host

From: Bjorn Helgaas
Date: Thu Aug 29 2024 - 12:51:50 EST


On Thu, Aug 29, 2024 at 12:38:58PM +0300, Sergei Shtylyov wrote:
> On 8/29/24 10:30 AM, WangYuli wrote:
> > + if (pdev->vendor == PCI_VENDOR_ID_PHYTIUM ||
>
> Hm, ||, not &&?
>
> > + pdev->device == PCI_DEVICE_ID_PHYTIUM_XHCI)
> > + xhci->quirks |= XHCI_RESET_ON_RESUME;

Definitely a bug, thanks for spotting it! Must check both Vendor
*and* Device ID. There are likely unrelated devices from other
vendors using the PCI_DEVICE_ID_PHYTIUM_XHCI Device ID value.