Re: [PATCH v6 11/26] rust: alloc: remove `BoxExt` extension
From: Benno Lossin
Date: Thu Aug 29 2024 - 14:40:42 EST
On 16.08.24 02:10, Danilo Krummrich wrote:
> Now that all existing `Box` users were moved to the kernel `Box` type,
> remove the `BoxExt` extension and all other related extensions.
>
> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> Signed-off-by: Danilo Krummrich <dakr@xxxxxxxxxx>
This is just a minor nit, but could you please change the commit title
to "rust: alloc: remove extension of std's `Box`"?
With that:
Reviewed-by: Benno Lossin <benno.lossin@xxxxxxxxx>
---
Cheers,
Benno
> ---
> rust/kernel/alloc.rs | 1 -
> rust/kernel/alloc/box_ext.rs | 80 ------------------------------------
> rust/kernel/init.rs | 44 +-------------------
> rust/kernel/lib.rs | 1 -
> rust/kernel/prelude.rs | 4 +-
> rust/kernel/types.rs | 28 -------------
> 6 files changed, 3 insertions(+), 155 deletions(-)
> delete mode 100644 rust/kernel/alloc/box_ext.rs