Re: [PATCH net-next v23 03/13] netdev: support binding dma-buf to netdevice

[Vadim Fedorenko]

On 29/08/2024 22:08, Jakub Kicinski wrote:
> On Thu, 29 Aug 2024 06:01:16 +0000 Mina Almasry wrote:
> > +	err = genlmsg_reply(rsp, info);
> > +	if (err)
> > +		goto err_unbind;
> > +
> >   	return 0;
> > +
> > +err_unbind:
>
> rtnl_lock()

There are 2 places with goto err_unbind, and one is under the lock,
additional label (or rearrange of the last check) is needed..

> > +	net_devmem_unbind_dmabuf(binding);
> > +err_unlock:
> > +	rtnl_unlock();