Re: [PATCH] bcachefs: Remove duplicate included headers

[Hongbo Li]

On 2024/8/29 23:49, Thorsten Blum wrote:
> The header files dirent_format.h and disk_groups_format.h are included
> twice. Remove the redundant includes and the following warnings reported
> by make includecheck:
>
>    disk_groups_format.h is included more than once
>    dirent_format.h is included more than once
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxxx>
> ---
>   fs/bcachefs/bcachefs_format.h | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/fs/bcachefs/bcachefs_format.h b/fs/bcachefs/bcachefs_format.h
> index 14ce726bf5a3..b97fd0f75831 100644
> --- a/fs/bcachefs/bcachefs_format.h
> +++ b/fs/bcachefs/bcachefs_format.h
> @@ -499,8 +499,6 @@ struct bch_sb_field {
>   #include "disk_groups_format.h"
>   #include "extents_format.h"
>   #include "ec_format.h"
> -#include "dirent_format.h"
> -#include "disk_groups_format.h"

line 497 and line 499.

Reviewed-by: Hongbo Li <lihongbo22@xxxxxxxxxx>


>   #include "inode_format.h"
>   #include "journal_seq_blacklist_format.h"
>   #include "logged_ops_format.h"