Re: [PATCH v2 0/6] pinctrl: intel: High impedance impl. and cleanups
From: Mika Westerberg
Date: Fri Aug 30 2024 - 00:51:51 EST
On Thu, Aug 29, 2024 at 04:59:14PM +0300, Andy Shevchenko wrote:
> We would need a high impedance implementation for a quirk, so here it
> is. While doing this series I also noticed a couple of opportunities
> to clean up, hence a few more patches (1st, 5th, and 6th).
>
> Series has been tested on Intel Meteor Lake-P.
>
> v2:
> - fixed a bug in patch 1 when applying debounce value
> - updated enum style (Mika)
> - made intel_gpio_set_high_impedance return void (Mika)
> - new patch to constify intel_get_community()
> - resplit "absolutely grotesque" macro to four (Mika)
> - ...and update more users, this shrinks binary a lot
>
> Andy Shevchenko (6):
> pinctrl: intel: Move debounce validation out of the lock
> pinctrl: intel: Refactor __intel_gpio_set_direction() to be more
> useful
> pinctrl: intel: Add __intel_gpio_get_direction() helper
> pinctrl: intel: Implement high impedance support
> pinctrl: intel: Constify intel_get_community() returned object
> pinctrl: intel: Introduce for_each_intel_gpio_group() helper et al.
I sent one minor comment for the last patch. For the series,
Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>