Re: [PATCH net-next V4 4/5] net: lan743x: Migrate phylib to phylink

[Raju Lakkaraju]

Hello Maxime,

Thank you for review the patches.

The 08/29/2024 09:49, Maxime Chevallier wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hello Raju,
> 
> On Thu, 29 Aug 2024 11:21:31 +0530
> Raju Lakkaraju <Raju.Lakkaraju@xxxxxxxxxxxxx> wrote:
> 
> > Migrate phy support from phylib to phylink.
> >
> > Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@xxxxxxxxxxxxx>
> 
> [...]
> 
> > +static void lan743x_phylink_disconnect(struct lan743x_adapter *adapter)
> > +{
> > +     struct net_device *netdev = adapter->netdev;
> > +     struct phy_device *phydev = netdev->phydev;
> > +
> > +     phylink_stop(adapter->phylink);
> > +     phylink_disconnect_phy(adapter->phylink);
> > +
> > +     if (phydev)
> > +             if (phy_is_pseudo_fixed_link(phydev))
> > +                     fixed_phy_unregister(phydev);
> 
> You shouldn't manually deal with the fixed_phy when using phylink, it
> handles fixed links already for you, without a PHY.

Sure.
I wll remove this fixed_phy unregister here.

> 
> Thanks,
> 
> Maxime

-- 
Thanks,                                                                         
Raju