RE: [PATCH net-next] r8169: add support for RTL8126A rev.b

[Hau]

> -----Original Message-----
> From: Heiner Kallweit [mailto:hkallweit1@xxxxxxxxx]
> Sent: Friday, August 30, 2024 1:34 PM
> To: Hau <hau@xxxxxxxxxxx>; nic_swsd <nic_swsd@xxxxxxxxxxx>;
> davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next] r8169: add support for RTL8126A rev.b
> 
> 
> External mail.
> 
> 
> 
> On 30.08.2024 04:18, ChunHao Lin wrote:
> > Add support for RTL8126A rev.b. Its XID is 0x64a. It is basically
> > based on the one with XID 0x649, but with different firmware file.
> >
> > Signed-off-by: ChunHao Lin <hau@xxxxxxxxxxx>
> > ---
> >  drivers/net/ethernet/realtek/r8169.h          |  1 +
> >  drivers/net/ethernet/realtek/r8169_main.c     | 42 ++++++++++++-------
> >  .../net/ethernet/realtek/r8169_phy_config.c   |  1 +
> >  3 files changed, 29 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/realtek/r8169.h
> > b/drivers/net/ethernet/realtek/r8169.h
> > index 00882ffc7a02..e2db944e6fa8 100644
> > --- a/drivers/net/ethernet/realtek/r8169.h
> > +++ b/drivers/net/ethernet/realtek/r8169.h
> > @@ -69,6 +69,7 @@ enum mac_version {
> >       RTL_GIGA_MAC_VER_61,
> >       RTL_GIGA_MAC_VER_63,
> >       RTL_GIGA_MAC_VER_65,
> > +     RTL_GIGA_MAC_VER_66,
> >       RTL_GIGA_MAC_NONE
> >  };
> >
> > diff --git a/drivers/net/ethernet/realtek/r8169_main.c
> > b/drivers/net/ethernet/realtek/r8169_main.c
> > index 3507c2e28110..3cb1c4f5c91a 100644
> > --- a/drivers/net/ethernet/realtek/r8169_main.c
> > +++ b/drivers/net/ethernet/realtek/r8169_main.c
> > @@ -56,6 +56,7 @@
> >  #define FIRMWARE_8125A_3     "rtl_nic/rtl8125a-3.fw"
> >  #define FIRMWARE_8125B_2     "rtl_nic/rtl8125b-2.fw"
> >  #define FIRMWARE_8126A_2     "rtl_nic/rtl8126a-2.fw"
> > +#define FIRMWARE_8126A_3     "rtl_nic/rtl8126a-3.fw"
> >
> 
> I checked linux-firmware repo, the new firmware isn't available there yet.
> Are you going to submit the firmware file?
> 
I will submit the new firmware file.

> Reviewed-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>