Re: [PATCH] fs: drop GFP_NOFAIL mode from alloc_page_buffers

[Hannes Reinecke]

On 8/29/24 21:17, Jan Kara wrote:
> On Thu 29-08-24 15:06:40, Michal Hocko wrote:
> > From: Michal Hocko <mhocko@xxxxxxxx>
> >
> > There is only one called of alloc_page_buffers and it doesn't require
> > __GFP_NOFAIL so drop this allocation mode.
> >
> > Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>
>
> Looks good. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
>
> Although even better fix would be to convert the last remaining caller of
> alloc_page_buffers() to folio_alloc_buffers()... But that may be more
> difficult.
Already done by Pankajs large-block patchset, currently staged in vfs.git.

Cheers,

Hannes
--
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@xxxxxxx                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich