Re: [PATCH v2 2/4] i2c: imx: separate atomic, dma and non-dma use case

From: Oleksij Rempel
Date: Fri Aug 30 2024 - 03:32:26 EST


On Mon, Aug 19, 2024 at 09:19:08AM +0200, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@xxxxxxxxxxx>
>
> Separate the atomic, dma and non-dma use case as a preparation step for
> moving the non-dma use case to the isr to avoid rescheduling while a
> transfer is in progress.
>
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@xxxxxxxxxxx>
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

I would prefer to rename i2c_imx_start_read() to i2c_imx_prepare_read()
With this change: Acked-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>

Thank you!

Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |