Re: [PATCH v2] platform/x86: dell-smbios: Fix error path in dell_smbios_init()
From: Ilpo Järvinen
Date: Fri Aug 30 2024 - 05:58:59 EST
On Fri, 30 Aug 2024 09:54:28 +0300, Aleksandr Mishin wrote:
> In case of error in build_tokens_sysfs(), all the memory that has been
> allocated is freed at end of this function. But then free_group() is
> called which performs memory deallocation again.
>
> Also, instead of free_group() call, there should be exit_dell_smbios_smm()
> and exit_dell_smbios_wmi() calls, since there is initialization, but there
> is no release of resources in case of an error.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: dell-smbios: Fix error path in dell_smbios_init()
commit: ffc17e1479e8e9459b7afa80e5d9d40d0dd78abb
--
i.