Re: [PATCH v5 1/8] perf trace: Fix iteration of syscall ids in syscalltbl->entries

From: Jiri Slaby
Date: Fri Aug 30 2024 - 06:29:30 EST


On 30. 08. 24, 12:24, Jiri Slaby wrote:
/usr/lib/gcc/i586-suse-linux/14/../../../../i586-suse-linux/bin/ld: (.text+0x8154c): undefined reference to `syscalltbl__id_at_idx'

Should there be something like a function returning identity mapping for !HAVE_SYSCALL_TABLE_SUPPORT?

Something like:
--- a/tools/perf/util/syscalltbl.c
+++ b/tools/perf/util/syscalltbl.c
@@ -178,6 +178,11 @@ int syscalltbl__id(struct syscalltbl *tbl, const char *name)
return audit_name_to_syscall(name, tbl->audit_machine);
}

+int syscalltbl__id_at_idx(struct syscalltbl *tbl, int idx)
+{
+ return idx;
+}
+
int syscalltbl__strglobmatch_next(struct syscalltbl *tbl __maybe_unused,
const char *syscall_glob __maybe_unused, int *idx __maybe_unused)
{

?

thanks,--
js