Re: CVE-2022-48936: gso: do not skip outer ip header in case of ipip and net_failover

From: Greg Kroah-Hartman
Date: Fri Aug 30 2024 - 06:44:55 EST


On Thu, Aug 29, 2024 at 01:07:36PM -0400, Willem de Bruijn wrote:
> On Thu, Aug 29, 2024 at 12:58 PM Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Thu, Aug 29, 2024 at 12:53:34PM -0400, Willem de Bruijn wrote:
> > > On Thu, Aug 29, 2024 at 12:18 PM Michal Koutný <mkoutny@xxxxxxxx> wrote:
> > > >
> > > > On Wed, Aug 28, 2024 at 09:30:08AM GMT, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > > > > What is the security issue here?
> > > > >
> > > > > This was assigned as part of the import of the Linux kernel GSD entries
> > > > > into CVEs as required by the CVE board of directors (hence the 2022
> > > > > date). If you don't feel this should be assigned a CVE, just let me
> > > > > know and I will be glad to reject it.
> > > >
> > > > The address of original author bounces back. Willem, could you please
> > > > help explaining context of the change? (~the questions in my previous
> > > > message).
> > >
> > > I don't know why this has a CVE.
> > >
> > > The patch reports that the negative effect is a drop due to a corrupted packet.
> > >
> > > According to the CVE report this requires both user input with
> > > virtio_net_hdr, which is privileged, and a tunnel device configured,
> > > which again is privileged.
> > >
> >
> > Ok, should it be rejected then? If so, just let me know.
>
> It is a legitimate bug fix, definitely stable material.
>
> With the fix backported to all these branches, not sure what, if
> anything, more is needed wrt the CVE.

Ok, for now I'll go revoke this as that feels the safest thing to do at
the moment.

The "frankenkernel" distros can decide if they want to pick this up or
not, everyone sane has had it for years now :)

thanks,

greg k-h