Re: [PATCH 1/1] Net: bcm.c: Remove Subtree Instead of Entry

From: Marc Kleine-Budde
Date: Fri Aug 30 2024 - 06:56:35 EST


On 09.08.2024 13:22:49, Kuniyuki Iwashima wrote:
> From: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
> Date: Fri, 9 Aug 2024 11:57:41 +0200
> > Hello David,
> >
> > many thanks for the patch and the description.
> >
> > Btw. the data structures of the elements inside that bcm proc dir should
> > have been removed at that point, so that the can-bcm dir should be empty.
> >
> > I'm not sure what happens to the open sockets that are (later) removed
> > in bcm_release() when we use remove_proc_subtree() as suggested.
> > Removing this warning probably does not heal the root cause of the issue.
>
> I posted a patch to fix bcm's proc entry leak few weeks ago, and this might
> be related.
> https://lore.kernel.org/netdev/20240722192842.37421-1-kuniyu@xxxxxxxxxx/
>
> Oliver, could you take this patch to can tree ?

That patch is included in my latest PR to net:

https://lore.kernel.org/all/20240829192947.1186760-1-mkl@xxxxxxxxxxxxxx

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature