Re: [PATCH 1/1] perf tests pmu: Initialize all fields of test_pmu variable

From: Arnaldo Carvalho de Melo
Date: Fri Aug 30 2024 - 09:37:19 EST


On Thu, Aug 29, 2024 at 08:49:05PM -0700, Namhyung Kim wrote:
> On Thu, Aug 29, 2024 at 2:09 PM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> > Being only in perf-tools-next:

> > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/commit/?h=perf-tools-next&id=37e2a19c98bf99747ca997be876dfc13f9165e0a

> > So yeah, probably Namhyung can cherry-pick that patch (Veronika's) into
> > perf-tools for v6.11.

> > There were a few more fixes that I noticed and picked for
> > perf-tools-next that then people reported that should also be
> > cherry-picked for v6.11, Namhyung?

> Ok, I can pick this up. I think my perf lock contention fix also can
> go to perf-tools.
> What others do you want me to pick up?

Here Ben points to one:

https://lore.kernel.org/all/d94d995e476a5c014e1ce4d75d36f8667acd3316.camel@xxxxxxxxxxxxxxx/T/#u

Which I think its this one:

commit 2518e13275ab9ea6b2540f828cf78b0280991f85
Author: Xu Yang <xu.yang_2@xxxxxxx>
Date: Mon Aug 19 10:34:03 2024 +0800

perf python: Fix the build on 32-bit arm by including missing "util/sample.h"

There is also this one:

commit 6236ebe07131a7746d870f1d8eb3637a8df13e70
Author: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Date: Mon Aug 19 16:46:29 2024 -0300

perf daemon: Fix the build on more 32-bit architectures

The previous attempt fixed the build on debian:experimental-x-mipsel,
but when building on a larger set of containers I noticed it broke the
build on some other 32-bit architectures such as:

42 7.87 ubuntu:18.04-x-arm : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04)
builtin-daemon.c: In function 'cmd_session_list':
builtin-daemon.c:692:16: error: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type 'long int' [-Werror=format=]

- Arnaldo