Re: [PATCH net v4] net: phy: Fix missing of_node_put() for leds

From: Andrew Lunn
Date: Fri Aug 30 2024 - 10:27:59 EST


On Fri, Aug 30, 2024 at 10:20:25AM +0800, Jinjie Ruan wrote:
> The call of of_get_child_by_name() will cause refcount incremented
> for leds, if it succeeds, it should call of_node_put() to decrease
> it, fix it.
>
> Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs")
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>

To be 100% correct, it should have a CC: stable@xxxxxxxxxxxxxxx

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#stable-tree

But it will probably be O.K. with it missing.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew