Re: [PATCH v3] nvme: fix metadata handling in nvme-passthrough

From: Keith Busch
Date: Fri Aug 30 2024 - 10:52:43 EST


On Thu, Aug 29, 2024 at 01:32:17PM +0000, Puranjay Mohan wrote:
> On an NVMe namespace that does not support metadata, it is possible to
> send an IO command with metadata through io-passthru. This allows issues
> like [1] to trigger in the completion code path.
> nvme_map_user_request() doesn't check if the namespace supports metadata
> before sending it forward. It also allows admin commands with metadata to
> be processed as it ignores metadata when bdev == NULL and may report
> success.
>
> Reject an IO command with metadata when the NVMe namespace doesn't
> support it and reject an admin command if it has metadata.
>
> [1] https://lore.kernel.org/all/mb61pcylvnym8.fsf@xxxxxxxxxx/

Thanks, applied to nvme-6.12.