Re: [PATCH v2] aarch64: vdso: Wire up getrandom() vDSO implementation

From: Jason A. Donenfeld
Date: Fri Aug 30 2024 - 11:21:47 EST


On Fri, Aug 30, 2024 at 04:19:00PM +0100, Mark Brown wrote:
> On Thu, Aug 29, 2024 at 08:17:14PM +0000, Adhemerval Zanella wrote:
> > Hook up the generic vDSO implementation to the aarch64 vDSO data page.
> > The _vdso_rng_data required data is placed within the _vdso_data vvar
> > page, by using a offset larger than the vdso_data.
>
> This exposes some preexisting compiler warnings in the getrandom test
> when built with clang:
>
> vdso_test_getrandom.c:145:40: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
> 145 | static void *test_vdso_getrandom(void *)
> | ^
> vdso_test_getrandom.c:155:40: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
> 155 | static void *test_libc_getrandom(void *)
> | ^
> vdso_test_getrandom.c:165:43: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
> 165 | static void *test_syscall_getrandom(void *)
> | ^
>
> which it'd be good to get fixed before merging.

That's my bug. I'll fix that up in the tree and CC you on it. Thanks for
pointing it out.

Jason