Re: [patch net-next v5] ethtool: pse-pd: move pse validation into set

From: Maxime Chevallier
Date: Fri Aug 30 2024 - 12:29:31 EST


Hi Diogo,

On Thu, 29 Aug 2024 15:48:27 -0300
Diogo Jahchan Koike <djahchankoike@xxxxxxxxx> wrote:

> Move validation into set, removing .set_validate operation as its current
> implementation holds the rtnl lock for acquiring the PHY device, defeating
> the intended purpose of checking before grabbing the lock.
>
> Reported-by: syzbot+ec369e6d58e210135f71@xxxxxxxxxxxxxxxxxxxxxxxxx
> Closes: https://syzkaller.appspot.com/bug?extid=ec369e6d58e210135f71
> Fixes: 31748765bed3 ("net: ethtool: pse-pd: Target the command to the requested PHY")
> Signed-off-by: Diogo Jahchan Koike <djahchankoike@xxxxxxxxx>

This looks good to me, thanks !

Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>

Maxime