Re: [v2,1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

From: György Kurucz
Date: Fri Aug 30 2024 - 13:36:53 EST


Dear Dmitry,

For context, I have a Lenovo Yoga Slim 7x laptop, and was having issues with the display staying black after sleep. As a workaround, I could switch to a different VT and back.

[ 1185.831970] [dpu error]connector not connected 3

I can confirm that I was seeing this exact error message as well.

if (!conn_state || !conn_state->connector) {
DPU_ERROR("invalid connector state\n");
return -EINVAL;
- } else if (conn_state->connector->status != connector_status_connected) {
- DPU_ERROR("connector not connected %d\n", conn_state->connector->status);
- return -EINVAL;
}
crtc = conn_state->crtc;

After applying this patch, the screen now resumes successfully, and the errors are gone.

(For future reference, I am using this kernel: https://github.com/jhovold/linux/commits/wip/x1e80100-6.11-rc5/, commit cc2cb95cc77fec43edd407c993122085fa8c2dd7.)

Tested-by: György Kurucz <me@xxxxxxxxxxxx>

Best regards,
György