Re: [PATCH v2] irqchip: Simplify with dev_err_probe()

[Krzysztof Kozlowski]

On 30/08/2024 10:17, Charles Keepax wrote:
> On Fri, Aug 30, 2024 at 03:05:04PM +0800, Yan Zhen wrote:
>> Switch to use dev_err_probe() to simplify the error path and
>> unify a message template.
>>
>> Using this helper is totally fine even if err is known to never
>> be -EPROBE_DEFER.
>>
>> The benefit compared to a normal dev_err() is the standardized format
>> of the error code, it being emitted symbolically and the fact that
>> the error code is returned which allows more compact error paths. 
>>
>> Signed-off-by: Yan Zhen <yanzhen@xxxxxxxx>
>> ---
> 
> Subject line probably should be irqchip/madera: but otherwise:
> 
> Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

No, this must stop. Do not change one line per patch.

Best regards,
Krzysztof