Re: [PATCH net-next 1/6] net: ag71xx: add COMPILE_TEST to test compilation

From: Simon Horman
Date: Fri Aug 30 2024 - 14:14:45 EST


On Fri, Aug 30, 2024 at 10:32:08AM -0700, Rosen Penev wrote:
> On Fri, Aug 30, 2024 at 8:49 AM Simon Horman <horms@xxxxxxxxxx> wrote:
> >
> > On Thu, Aug 29, 2024 at 02:48:20PM -0700, Rosen Penev wrote:
> > > While this driver is meant for MIPS only, it can be compiled on x86 just
> > > fine. Remove pointless parentheses while at it.
> > >
> > > Enables CI building of this driver.
> > >
> > > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> >
> > Thanks, this seems to work well.
> >
> > Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
> >
> > As a follow-up, could you consider adding a MODULE_DESCRIPTION()
> > to this module. It now gets flagged on x86_64 allmodconfig W=1 builds.
> v2 patchset?

I'd wait to see if this patchset is accepted.
And if so, send a new patch separately.
If not, perhaps add it to v2.