Re: [PATCH v2 1/2] Tracking cgroup-level niced CPU time
From: Tejun Heo
Date: Fri Aug 30 2024 - 15:41:53 EST
On Fri, Aug 30, 2024 at 07:19:38AM -0700, Joshua Hahn wrote:
> From: Joshua Hahn <joshua.hahn6@xxxxxxxxx>
>
> Cgroup-level CPU statistics currently include time spent on
> user/system processes, but do not include niced CPU time (despite
> already being tracked). This patch exposes niced CPU time to the
> userspace, allowing users to get a better understanding of their
> hardware limits and can facilitate more informed workload distribution.
>
> A new field 'ntime' is added to struct cgroup_base_stat as opposed to
> struct task_cputime to minimize footprint.
Patch looks fine to me but can you please do the followings?
- Add subsystem prefix to the patch titles. Look other commits for examples.
- Add Signed-off-by to both.
Thanks.
--
tejun