Re: [PATCH v3 1/8] x86/virt/tdx: Rename 'struct tdx_tdmr_sysinfo' to reflect the spec better
From: Dan Williams
Date: Fri Aug 30 2024 - 18:06:17 EST
Kai Huang wrote:
> The TDX module provides a set of "global metadata fields". They report
> things like TDX module version, supported features, and fields related
> to create/run TDX guests and so on.
>
> TDX organizes those metadata fields by "Class"es based on the meaning of
> those fields. E.g., for now the kernel only reads "TD Memory Region"
> (TDMR) related fields for module initialization. Those fields are
> defined under class "TDMR Info".
>
> There are both immediate needs to read more metadata fields for module
> initialization and near-future needs for other kernel components like
> KVM to run TDX guests. To meet all those requirements, the idea is the
> TDX host core-kernel to provide a centralized, canonical, and read-only
> structure for the global metadata that comes out from the TDX module for
> all kernel components to use.
>
> More specifically, the target is to end up with something like:
>
> struct tdx_sys_info {
> struct tdx_sys_info_classA a;
> struct tdx_sys_info_classB b;
> ...
> };
>
> Currently the kernel organizes all fields under "TDMR Info" class in
> 'struct tdx_tdmr_sysinfo'. To prepare for the above target, rename the
> structure to 'struct tdx_sys_info_tdmr' to follow the class name better.
>
> No functional change intended.
>
> Signed-off-by: Kai Huang <kai.huang@xxxxxxxxx>
> ---
> v2 -> v3:
> - Split out as a separate patch and place it at beginning:
>
> https://lore.kernel.org/kvm/cover.1721186590.git.kai.huang@xxxxxxxxx/T/#m8fec7c429242d640cf5e756eb68e3b822e6dff8b
>
> - Rename to 'struct tdx_sys_info_tdmr':
>
> https://lore.kernel.org/kvm/cover.1721186590.git.kai.huang@xxxxxxxxx/T/#md73dd9b02a492acf4a6facae63e8d030e320967d
> https://lore.kernel.org/kvm/cover.1721186590.git.kai.huang@xxxxxxxxx/T/#m8fec7c429242d640cf5e756eb68e3b822e6dff8b
>
> ---
> arch/x86/virt/vmx/tdx/tdx.c | 36 ++++++++++++++++++------------------
> arch/x86/virt/vmx/tdx/tdx.h | 2 +-
> 2 files changed, 19 insertions(+), 19 deletions(-)
Looks good to me,
Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>