Re: [PATCH v1] gpio: stmpe: Simplify with dev_err_probe()

[Linus Walleij]

On Thu, Aug 29, 2024 at 3:11 PM Shen Lichuan <shenlichuan@xxxxxxxx> wrote:

> Use dev_err_probe() to simplify the error path and unify a message
> template.
>
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.
>
> The benefit compared to a normal dev_err() is the standardized format
> of the error code, it being emitted symbolically and the fact that
> the error code is returned which allows more compact error paths.
>
> Signed-off-by: Shen Lichuan <shenlichuan@xxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij