Re: [PATCH 02/11] sched_ext: Refactor consume_remote_task()
From: Tejun Heo
Date: Sat Aug 31 2024 - 01:33:28 EST
Hello,
On Fri, Aug 30, 2024 at 11:05:16PM -0500, David Vernet wrote:
...
> Not a functional change from the prior patch, but it occurred to me that
> if we just deactivate like this then we'll also fire the ops.quiescent()
> callback in dequeue_task_scx(). Should we add a check to skip the
> dequeue callbacks if p->scx.holding_cpu >= 0?
Right, migrations shouldn't trigger quiescent / runnable events. We should
be able to suppress based on holding_cpu and sticky_cpu. Will look into
that.
Thanks.
--
tejun