Re: [PATCH v2 2/4] irqchip/apple-aic: Skip unnecessary setting of use_fast_ipi
From: Sven Peter
Date: Sat Aug 31 2024 - 02:48:44 EST
> On 31. Aug 2024, at 07:57, Nick Chan <towinchenmi@xxxxxxxxx> wrote:
>
> use_fast_ipi is true by default and there is no need to "enable" it.
>
> Signed-off-by: Nick Chan <towinchenmi@xxxxxxxxx>
> ---
Acked-by: Sven Peter <sven@xxxxxxxxxxxxx>
> drivers/irqchip/irq-apple-aic.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 5c534d9fd2b0..8d81d5fb3c50 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -987,9 +987,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p
> off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */
> off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */
>
> - if (irqc->info.fast_ipi)
> - static_branch_enable(&use_fast_ipi);
> - else
> + if (!irqc->info.fast_ipi)
> static_branch_disable(&use_fast_ipi);
>
> irqc->info.die_stride = off - start_off;
> --
> 2.46.0
>