Re: [PATCH v5] LoongArch: vDSO: Wire up getrandom() vDSO implementation

From: Huacai Chen
Date: Sat Aug 31 2024 - 03:10:38 EST


On Sat, Aug 31, 2024 at 2:40 PM Xi Ruoyao <xry111@xxxxxxxxxxx> wrote:
>
> On Thu, 2024-08-29 at 21:18 +0800, Huacai Chen wrote:
> > > -obj-vdso-y := elf.o vgetcpu.o vgettimeofday.o sigreturn.o
> > > +obj-vdso-y := elf.o vgetcpu.o vgettimeofday.o sigreturn.o vgetrandom.o \
> > > + vgetrandom-chacha.o
>
> Huacai: do you prefer to remove this line break as well, or Makefile
> still has a line width limit?
Also no limit, but Makefile is more or less different because there is
no "statement" and doesn't affect our understanding.

So, line break is fine here (but for my own preference I like to keep
sigreturn.o at last).

Huacai

>
> --
> Xi Ruoyao <xry111@xxxxxxxxxxx>
> School of Aerospace Science and Technology, Xidian University