Re: [PATCH v3 1/2] dt-bindings: mmc: sdhci-atmel: Convert to json schema

[Dharma.B]

Hi Krzysztof,

On 31/08/24 11:49 am, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Fri, Aug 30, 2024 at 08:21:20PM +0530, Dharma Balasubiramani wrote:
>> Convert sdhci-atmel documentation to yaml format. The new file will inherit
>> from sdhci-common.yaml.
>>
>> Note: Add microchip,sama7g5-sdhci to compatible list as we already use it
>> in the DT.
>>
>> Signed-off-by: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx>
>> ---
>>   .../bindings/mmc/atmel,sama5d2-sdhci.yaml          | 90 ++++++++++++++++++++++
>>   .../devicetree/bindings/mmc/sdhci-atmel.txt        | 35 ---------
>>   2 files changed, 90 insertions(+), 35 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
>> new file mode 100644
>> index 000000000000..ba4786328833
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mmc/atmel,sama5d2-sdhci.yaml
>> @@ -0,0 +1,90 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mmc/atmel,sama5d2-sdhci.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Atmel SDHCI controller
>> +
>> +maintainers:
>> +  - Aubin Constans <aubin.constans@xxxxxxxxxxxxx>
>> +  - Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
>> +
>> +description:
>> +  Bindings for the SDHCI controller found in Atmel/Microchip SoCs.
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - enum:
>> +          - atmel,sama5d2-sdhci
>> +          - atmel,sama5d3-sdhci
> 
> This wasn't in the old binding.
> 
>> +          - atmel,sama5d4-sdhci
> 
> Neither this.

My bad, I accidentally added those compatibles that are not present in 
the old binding or the DTS files.

> 
>> +          - microchip,sam9x60-sdhci
>> +      - items:
>> +          - enum:
>> +              - microchip,sama7g5-sdhci
>> +          - const: microchip,sam9x60-sdhci
> 
> What happened with microchip,sam9x7-sdhci compatible from the old binding?
> 
> And none of above changes are explained in commit msg.

Since there are no users of microchip,sam9x7-sdhci compatible from the 
old binding I missed adding it during the conversion.

I'll correct these issues and make the necessary adjustments (remove the 
"atmel,sama5d3-sdhci" and "atmel,sama5d4-sdhci" compatibles and add back 
the "microchip,sam9x7-sdhci" compatible) in the next revision of this 
patch series.

Thanks.

> 
> 
> 
> Best regards,
> Krzysztof
> 
> 


-- 
With Best Regards,
Dharma B.