RE: [PATCH v1] netronome: nfp: Use min macro
From: David Laight
Date: Sat Aug 31 2024 - 08:50:58 EST
From: Jakub Kicinski
> Sent: 27 August 2024 15:24
>
> On Tue, 27 Aug 2024 16:40:05 +0800 Yan Zhen wrote:
> > Using min macro not only makes the code more concise and readable
> > but also improves efficiency sometimes.
>
> The code is fine, you're making it worse.
>
> How many of those pointless min()/max() conversions do you have
> for drivers/net ?
Maybe someone who understands cochineal should change the pattern
so that is require one of the 'arguments' to be non-trivial.
(or perhaps just delete the script ;-)
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)