Re: [PATCH] dt-bindings: clock: Add SAMA7D65 PMC compatible string

From: claudiu beznea
Date: Sat Aug 31 2024 - 09:32:53 EST




On 29.08.2024 12:38, Dharma Balasubiramani wrote:
> Add the `microchip,sama7d65-pmc` compatible string to the existing binding,
> since the SAMA7D65 PMC shares the same properties and clock requirements
> as the SAMA7G5.

Looks a bit odd to me to publish bindings and driver chances by 2 different
people, at exactly the same time. Maybe coordinate and publish it together
(at least for the future).

Other than this:

Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxx>


>
> Signed-off-by: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> index c9eb60776b4d..885d47dd5724 100644
> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml
> @@ -43,6 +43,7 @@ properties:
> - atmel,sama5d4-pmc
> - microchip,sam9x60-pmc
> - microchip,sam9x7-pmc
> + - microchip,sama7d65-pmc
> - microchip,sama7g5-pmc
> - const: syscon
>
> @@ -90,6 +91,7 @@ allOf:
> enum:
> - microchip,sam9x60-pmc
> - microchip,sam9x7-pmc
> + - microchip,sama7d65-pmc
> - microchip,sama7g5-pmc
> then:
> properties:
>
> ---
> base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e
> change-id: 20240829-sama7d65-next-a91d089b56a3
>
> Best regards,