RE: [EXTERNAL] Re: [net-next PATCH v11 03/11] octeontx2-pf: Create representor netdev

[Geethasowjanya Akula]

>-----Original Message-----
>From: Jiri Pirko <jiri@xxxxxxxxxxx>
>Sent: Thursday, August 22, 2024 7:50 PM
>To: Geethasowjanya Akula <gakula@xxxxxxxxxxx>
>Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kuba@xxxxxxxxxx;
>davem@xxxxxxxxxxxxx; pabeni@xxxxxxxxxx; edumazet@xxxxxxxxxx; Sunil
>Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta
><sbhatta@xxxxxxxxxxx>; Hariprasad Kelam <hkelam@xxxxxxxxxxx>
>Subject: [EXTERNAL] Re: [net-next PATCH v11 03/11] octeontx2-pf: Create
>representor netdev
>
>Thu, Aug 22, 2024 at 03:20:23PM CEST, gakula@xxxxxxxxxxx wrote:
>>Adds initial devlink support to set/get the switchdev mode.
>>Representor netdevs are created for each rvu devices when the switch
>>mode is set to 'switchdev'. These netdevs are be used to control and
>>configure VFs.
>>
>>Signed-off-by: Geetha sowjanya <gakula@xxxxxxxxxxx>
>>Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
>>---
>> .../ethernet/marvell/octeontx2.rst            |  53 ++++++
>> .../marvell/octeontx2/nic/otx2_devlink.c      |  49 ++++++
>> .../net/ethernet/marvell/octeontx2/nic/rep.c  | 165 ++++++++++++++++++
>> .../net/ethernet/marvell/octeontx2/nic/rep.h  |   3 +
>> 4 files changed, 270 insertions(+)
>>
>>diff --git
>>a/Documentation/networking/device_drivers/ethernet/marvell/octeontx2.rs
>>t
>>b/Documentation/networking/device_drivers/ethernet/marvell/octeontx2.rs
>>t index 1e196cb9ce25..1132ae2d007c 100644
>>---
>>a/Documentation/networking/device_drivers/ethernet/marvell/octeontx2.rs
>>t
>>+++ b/Documentation/networking/device_drivers/ethernet/marvell/octeontx
>>+++ 2.rst
>>@@ -14,6 +14,7 @@ Contents
>> - `Basic packet flow`_
>> - `Devlink health reporters`_
>> - `Quality of service`_
>>+- `RVU representors`_
>>
>> Overview
>> ========
>>@@ -340,3 +341,55 @@ Setup HTB offload
>>         # tc class add dev <interface> parent 1: classid 1:2 htb rate
>>10Gbit prio 2 quantum 188416
>>
>>         # tc class add dev <interface> parent 1: classid 1:3 htb rate
>> 10Gbit prio 2 quantum 32768
>>+
>>+
>>+RVU Representors
>>+================
>>+
>>+RVU representor driver adds support for creation of representor
>>+devices for RVU PFs' VFs in the system. Representor devices are
>>+created when user enables the switchdev mode.
>>+Switchdev mode can be enabled either before or after setting up SRIOV
>numVFs.
>>+All representor devices share a single NIXLF but each has a dedicated
>>+queue (ie RQ/SQ. RVU PF representor driver registers a separate netdev
>>+for each RQ/SQ queue pair.
>>+
>>+HW doesn't have a in-built switch which can do L2 learning and forward
>>+pkts between representee and representor. Hence packet path between
>>+representee and it's representor is achieved by setting up appropriate NPC
>MCAM filters.
>
>Isn't this documentation part talking about bits added in patch
>"octeontx2-af: Add packet path between representor and VF"
>? If yes, move the docs to that patch. Please make sure you add code alongside
>with documentation. Or, alternativelly, just let the documentation be added by
>separate and last patch.
>
>[..]
Will add a separate patch for documentation.