Re: [PATCH v2 18/19] x86/asm-prototypes: Include <asm/ptrace.h>

[Masahiro Yamada]

On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
>
> <asm/ftrace.h> refers to struct pt_regs, make sure it's visible.
>
> Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>


Then, why don't you include <asm/ptrace.h>
from arch/x86/include/asm/ftrace.h
instead of from arch/x86/include/asm/asm-prototypes.h


And, this patch can get in independently.

You should send it as a standalone patch
to the x86 ML.







> ---
>  arch/x86/include/asm/asm-prototypes.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/include/asm/asm-prototypes.h b/arch/x86/include/asm/asm-prototypes.h
> index 25466c4d2134..c82e68c8b7c2 100644
> --- a/arch/x86/include/asm/asm-prototypes.h
> +++ b/arch/x86/include/asm/asm-prototypes.h
> @@ -1,4 +1,5 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
> +#include <asm/ptrace.h>
>  #include <asm/ftrace.h>
>  #include <linux/uaccess.h>
>  #include <linux/pgtable.h>
> --
> 2.46.0.184.g6999bdac58-goog
>


--
Best Regards
Masahiro Yamada