Re: [PATCH v3] timekeeping: Use time_after() in timekeeping_check_update()

From: Thomas Gleixner
Date: Sun Sep 01 2024 - 15:01:26 EST


On Fri, Aug 30 2024 at 09:54, Chen Yufan wrote:
> Use time_after because the open coded comparison
> does not handle wrap arounds correctly.
>
> Signed-off-by: Chen Yufan <chenyufan@xxxxxxxx>
> ---
> The modifications made compared to the previous version are as follows:
> 1. change the type of timekeeper::last_warning to
> unsigned long because time_after() requires its
> parameters to be unsigned long.

The change of the struct member wants to be explained in the change log
and not in the version history. I told you so, no?

Thanks,

tglx