Re: [net-next PATCH v7 1/8] octeontx2-pf: map skb data as device writeable

[Bharat Bhushan]

On Thu, Aug 29, 2024 at 8:18 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Thu, 29 Aug 2024 11:17:25 +0530 Bharat Bhushan wrote:
> > > How did you test this prior to adding skb_unshare()?
> > > Could you share some performance data with this change?
> >
> > testing using flood ping and iperf with multiple instance,
>
> Makes sense, neither of these will detect corruption of data pages :(
> IIRC iperf just ignores the data, ping doesn't retransmit.
> You gotta beef up your testing...
>
> > I do not see any drop in performance numbers
>
> Well. What's the difference in CPU busy time of v5 vs v7?
> You'll copy all TCP packets, they are (pretty much) all clones.

cpu is 5-8% more busy when skb unshare.

Thanks
-Bharat