Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Add Variscite Symphony board and VAR-SOM-MX8MP SoM

From: Krzysztof Kozlowski
Date: Mon Sep 02 2024 - 03:47:40 EST


On 02/09/2024 09:23, Tarang Raval wrote:
> Hi,
>
>>> as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp."
>>
>> ??? No, there is no difference. You did not test your patches either.
>
> I did test my patches using "dt_binding_check" and "CHECK_DTBS," and there were no warnings or errors.

Ah, you are right, I missed what actually changed.

>
>> When I wrote "This is not correct", it means you should drop it.
>> Incorrect compatibles should not be added.
>
> Sure I will Drop it.

I guess I wasn't precise. Please drop that one diff hunk.

Best regards,
Krzysztof