Re: [PATCH] x86/sgx: Fix deadloop in __sgx_alloc_epc_page()
From: Aaron Lu
Date: Mon Sep 02 2024 - 03:57:47 EST
On Fri, Aug 30, 2024 at 07:03:33AM -0700, Dave Hansen wrote:
> On 8/29/24 23:02, Aaron Lu wrote:
> >> Also, I do think we should probably add some kind of sanity warning to
> >> the SGX code in another patch. If a node on an SGX system has CPUs and
> >> memory, it's very likely it will also have some EPC. It can be
> >> something soft like a pr_info(), but I think it would be nice to have.
> > I think there are systems with valid reason to not setup an EPC section
> > per node, e.g. a 8 sockets system with SNC=2, there would be a total of
> > 16 nodes and it's not possible to have one EPC section per node because
> > the upper limit of EPC sections is 8. I'm not sure a warning is
> > appropriate here, what do you think?
>
> While possible, those systems are pretty rare. I don't think a
> softly-worded pr_info() will scare anyone too much.
Understood.
Maybe something like below?