Re: [PATCH 1/3] drm/bridge: microchip-lvds: Revert clk_prepare_enable() in case of failure

[Dharma.B]

Hi Claudiu,

On 02/09/24 1:48 pm, claudiu beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 02.09.2024 07:39, Dharma.B@xxxxxxxxxxxxx wrote:
>> On 27/08/24 9:42 pm, Claudiu Beznea wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> In case pm_runtime_get_sync() fails the clock remains enabled. Disable
>>> it to save power on this failure scenario.
>>>
>>> Fixes: 179b0769fc5f ("drm/bridge: add lvds controller support for sam9x7")
>>> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxx>
>> Reviewed-and-tested-by: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx>
> 
> This tag is not valid, AFAIK. You should use 2 different tags: Reviewed-by,
> Tested-by
Okay, I don't know how these got in

linux$ git log | grep Reviewed-and-tested-by
     Reviewed-and-tested-by: Jiadong Zhu <Jiadong.Zhu@xxxxxxx>
     Reviewed-and-tested-by: Jiadong Zhu <Jiadong.Zhu@xxxxxxx>
     Reviewed-and-tested-by: Raghavendra K T <raghavendra.kt@xxxxxxx>
     Reviewed-and-tested-by: K Prateek Nayak <kprateek.nayak@xxxxxxx>
     Reviewed-and-tested-by: Athira Rajeev <atrajeev@xxxxxxxxxxxxxxxxxx>
     Reviewed-and-tested-by: Athira Rajeev <atrajeev@xxxxxxxxxxxxxxxxxx>
     Reviewed-and-tested-by: Athira Rajeev <atrajeev@xxxxxxxxxxxxxxxxxx>
     Reviewed-and-tested-by: Madadi Vineeth Reddy <vineethr@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Jan Karcher <jaka@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Jan Karcher <jaka@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Jan Karcher <jaka@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Jan Karcher <jaka@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Jan Karcher <jaka@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Jan Karcher <jaka@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Jan Karcher <jaka@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Jan Karcher <jaka@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Jan Karcher <jaka@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Jan Karcher <jaka@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Jan Karcher <jaka@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Chen Yu <yu.c.chen@xxxxxxxxx>
     Reviewed-and-tested-by: Haibo Chen <haibo.chen@xxxxxxx>
     Reviewed-and-tested-by: Jingbo Xu <jefflexu@xxxxxxxxxxxxxxxxx>
     Reviewed-and-tested-by: Xiongwei Song <xiongwei.song@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Xiongwei Song <xiongwei.song@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Mathieu Desnoyers 
<mathieu.desnoyers@xxxxxxxxxxxx>
     Reviewed-and-tested-by: Geliang Tang <geliang@xxxxxxxxxx>
     Reviewed-and-tested-by: Geliang Tang <geliang@xxxxxxxxxx>
     Reviewed-and-tested-by: Davidlohr Bueso <dave@xxxxxxxxxxxx>
     Reviewed-and-tested-by: Jiadong Zhu <Jiadong.Zhu@xxxxxxx>
     Reviewed-and-tested-by: Wenjia Zhang <wenjia@xxxxxxxxxxxxx>
     Reviewed-and-tested-by: Wenjia Zhang <wenjia@xxxxxxxxxxxxx>
:
:
:
> 
>>> ---
>>>    drivers/gpu/drm/bridge/microchip-lvds.c | 1 +
>>>    1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
>>> index b8313dad6072..027292ab0197 100644
>>> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
>>> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
>>> @@ -125,6 +125,7 @@ static void mchp_lvds_enable(struct drm_bridge *bridge)
>>>
>>>           ret = pm_runtime_get_sync(lvds->dev);
>>>           if (ret < 0) {
>>> +               clk_disable_unprepare(lvds->pclk);
>>>                   dev_err(lvds->dev, "failed to get pm runtime: %d\n", ret);
>>>                   return;
>>>           }
>>> --
>>> 2.39.2
>>>
>>
>>


-- 
With Best Regards,
Dharma B.