Re: [PATCH net-next v2] net: ipa: make use of dev_err_cast_probe()

[Simon Horman]

On Thu, Aug 29, 2024 at 11:07:39AM +0800, Yuesong Li wrote:
> Using dev_err_cast_probe() to simplify the code.
> 
> Signed-off-by: Yuesong Li <liyuesong@xxxxxxxx>
> Signed-off-by: Hongbo Li <lihongbo22@xxxxxxxxxx>
> ---
> v2: https://lore.kernel.org/all/20240828160728.GR1368797@xxxxxxxxxx/
>   - fix patch name
>   - drop the {} and fix the alignment

Thanks for hte updates.

I note that this code is in a probe function,
so this patch is an appropriate use of dev_err_cast_probe() [1].

I also see that it addresses the feedback on code style from v1.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>


[1] [PATCH] net: alacritech: Partially revert "net: alacritech: Switch to use dev_err_probe()"
    https://lore.kernel.org/netdev/20240830170014.15389-1-krzysztof.kozlowski@xxxxxxxxxx/

...