Re: [PATCH net-next v2 1/3] net: dsa: microchip: rename ksz8 series files

[Pieter]

Hi Arun,

> > -         This driver adds support for Microchip KSZ9477 series
> > switch and
> > -         KSZ8795/KSZ88x3 switch chips.
> > +         This driver adds support for Microchip KSZ9477 series,
> > +         LAN937X series and KSZ8 series switch chips, being
> > +         KSZ9477/9896/9897/9893/9563/9567,
>
> You missed KSZ8567 and KSZ8563. Also it could be in order as suggested
> by Tristram,
> -  KSZ8863/8873, KSZ8895/8864, KSZ8794/8795/8765
> -  KSZ9477/9897/9896/9567/8567
> -  KSZ9893/9563/8563
> -  LAN9370/9371/9372/9373/9374

OK will do.

> > + * It supports the following switches:
> > + * - KSZ8863, KSZ8873 aka KSZ88X3
> > + * - KSZ8895, KSZ8864 aka KSZ8895 family
>
> You can remove 'family' here, so as to be consistent.

Well I'd rather keep it so it's consistent with the ksz_common.h
ksz_is_8895_family(), do you agree?

> > + * - KSZ8794, KSZ8795, KSZ8765 aka KSZ87XX
> > + * Note that it does NOT support:
> > + * - KSZ8563, KSZ8567 - see KSZ9477 driver
> >   *
> >   * Copyright (C) 2017 Microchip Technology Inc.
> >   *     Tristram Ha <Tristram.Ha@xxxxxxxxxxxxx>
> > @@ -23,7 +30,7 @@
> >  #include <linux/phylink.h>
> >

Cheers, Pieter