Re: [PATCH] gpio: kerneldoc fixes for excess members
From: Bartosz Golaszewski
Date: Mon Sep 02 2024 - 06:10:11 EST
On Tue, Aug 27, 2024 at 4:02 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Tue, Aug 27, 2024 at 4:55 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> > On 26/08/2024 19:25, Andy Shevchenko wrote:
> > > On Mon, Aug 26, 2024 at 06:18:50PM +0200, Krzysztof Kozlowski wrote:
>
> > >> Drop kerneldoc descriptions of struct members which do not exist to fix
> > >> W=1 warnings:
> > >>
> > >> drivers/gpio/gpio-pch.c:101: warning: Excess struct member 'lock' description in 'pch_gpio'
> > >> drivers/gpio/gpio-syscon.c:46: warning: Excess struct member 'compatible' description in 'syscon_gpio_data'
> > >
> > > I prefer on per-driver basis, but since it's simple and I have nothing
> > > in my queue,
> >
> > These are so trivial without impact on the code, even if W=1 reports
> > them, that it would be quite a churn to handle multiple patches.
>
> Even trivial changes may lead to Git conflicts if managed separately.
> But as I said, there is nothing in my queue (at all) so there are no
> chances for conflicts.
>
Is this an Ack for me to take these or do you want them to go through your tree?
Bart