AW: [PATCH 1/2] dt-bindings: hwmon: Introduce ADS71x8

From: Sperling, Tobias
Date: Mon Sep 02 2024 - 08:58:59 EST


Hi,
thanks for the feedback in general.

> > Documentation/hwmon/ads71x8.rst | 140 ++++++++++++++++++
> > Documentation/hwmon/index.rst | 1 +
>
> And these two documents are not dt-bindings, so they should either be in
> their own commit or alongside the driver. Not sure how Guenter likes
> things.

Ok, probably misunderstood some documentation then, that everything in
Documentation/ should be a separate commit. Would move it then alongside
the driver, if that's fine from your side.

> > +description: |
> > + The ADS7128 is 12-Bit, 8-Channel Sampling Analog to Digital Converter (ADC)
> > + with an I2C interface.
> > +
> > + Datasheets:
> > + https://www.ti.com/product/ADS7128
> > + https://www.ti.com/product/ADS7138
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - ti,ads7128
> > + - ti,ads7138
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + avdd-supply:
>
> There's also a dvdd on the ads7128.

Yes, but it doesn't affect anything in the driver. Does it still need to be documented then?

> oCheers,
> Conor.

Regards
Tobias