Re: [PATCH v11 03/38] clk: ep93xx: add DT support for Cirrus EP93xx

[Nikita Shubin]

On Fri, 2024-08-30 at 15:27 -0700, Stephen Boyd wrote:
> Quoting Nikita Shubin (2024-08-30 02:23:12)
> > Hello Stephen!
> > 
> > On Wed, 2024-08-28 at 13:44 -0700, Stephen Boyd wrote:
> > > Quoting Nikita Shubin via B4 Relay (2024-07-15 01:38:07)
> > > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> > > > index 3e9099504fad..234b0a8b7650 100644
> > > > --- a/drivers/clk/Kconfig
> > > > +++ b/drivers/clk/Kconfig
> > > > @@ -218,6 +218,14 @@ config COMMON_CLK_EN7523
> > > >           This driver provides the fixed clocks and gates
> > > > present
> > > > on Airoha
> > > >           ARM silicon.
> > > >  
> > > > +config COMMON_CLK_EP93XX
> > > > +       bool "Clock driver for Cirrus Logic ep93xx SoC"
> > > 
> > > tristate?
> > > 
> > > > +       depends on ARCH_EP93XX || COMPILE_TEST
> > > > +       select MFD_SYSCON
> > > 
> > > Why is this selecting syscon?
> > > 
> > > > +       select REGMAP
> > > 
> > > Is this needed either?
> > 
> > Indeed REGMAP is selected by COMMON_CLK, MFD_SYSCON not required,
> > but
> > it needs AUXILIARY_BUS.
> 
> I don't see REGMAP selected by COMMON_CLK. Did I miss something?

Indeed REGMAP is selected by COMMON_CLK_MESON_REGMAP not COMMON_CLK on
make tinyconfig + COMPILE_TEST.

Then we require REGMAP because we are using regmap_read() in clk
driver.

> 
> > 
> > > > +#define
> > > > devm_ep93xx_clk_hw_register_fixed_rate_parent_data(dev,
> > > > name, parent_data, flags, fixed_rate)  \
> > > > +       __clk_hw_register_fixed_rate((dev), NULL, (name), NULL,
> > > > NULL, \
> > > > +                                    (parent_data), (flags),
> > > > (fixed_rate), 0, 0, true)
> > > 
> > > Is this to workaround a missing
> > > devm_clk_hw_register_fixed_rate_parent_data() macro?
> > 
> > Yes, if it's okay - i'll fire next revision, all other comments are
> > acknowledged.
> > 
> 
> Can you add the macro so others can use it in another patch?

Sure.